Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Island: Use MONGO_URL instead of hard-coded values for flask-security #4172

Merged
merged 1 commit into from
May 10, 2024

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented May 9, 2024

What does this PR do?

Addresses the issue by parsing MONGO_URL into its constituent parts and using them to set the values provided to flask-security.

Issue #4170.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by running monkey-island and mongo in a docker-compose script, setting the MONKEY_MONGO_URL using the mongo service name

  • If applicable, add screenshots or log transcripts of the feature working

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.07%. Comparing base (9324b32) to head (e7c59c7).
Report is 1 commits behind head on develop.

❗ Current head e7c59c7 differs from pull request most recent head 3e7073f. Consider uploading reports for the commit 3e7073f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4172      +/-   ##
===========================================
- Coverage    77.07%   77.07%   -0.01%     
===========================================
  Files          444      444              
  Lines        14136    14138       +2     
  Branches        18       18              
===========================================
+ Hits         10896    10897       +1     
- Misses        3240     3241       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mssalvatore mssalvatore force-pushed the 4170-fix-monkey-mongo-url branch from e7c59c7 to 3e7073f Compare May 10, 2024 19:51
@mssalvatore mssalvatore merged commit 3e7073f into develop May 10, 2024
1 check failed
@mssalvatore mssalvatore deleted the 4170-fix-monkey-mongo-url branch May 10, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants