Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Island: Remove f-string from MONGO_URL #4174

Merged
merged 1 commit into from
May 13, 2024

Conversation

ilija-lazoroski
Copy link
Contributor

What does this PR do?

Related to #4170.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

Comment on lines 8 to 10
"mongodb://{0}:{1}/{2}".format(
DEFAULT_MONGO_DB_HOST, DEFAULT_MONGO_DB_PORT, DEFAULT_MONGO_DB_NAME
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"mongodb://{0}:{1}/{2}".format(
DEFAULT_MONGO_DB_HOST, DEFAULT_MONGO_DB_PORT, DEFAULT_MONGO_DB_NAME
),
f"mongodb://{DEFAULT_MONGO_DB_HOST}:{DEFAULT_MONGO_DB_PORT}/{DEFAULT_MONGO_DB_NAME}"

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.07%. Comparing base (3e7073f) to head (2db7e6f).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4174   +/-   ##
========================================
  Coverage    77.07%   77.07%           
========================================
  Files          444      444           
  Lines        14138    14138           
  Branches        18       18           
========================================
  Hits         10897    10897           
  Misses        3241     3241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ilija-lazoroski ilija-lazoroski force-pushed the 4170-fix-monkey-mongo-url-string branch from d2c11e2 to 2db7e6f Compare May 13, 2024 09:47
@mssalvatore mssalvatore merged commit 290fdc7 into develop May 13, 2024
2 of 3 checks passed
@mssalvatore mssalvatore deleted the 4170-fix-monkey-mongo-url-string branch May 13, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants