Implemented redaction functions to obscure sensitive information in strings #1217
+247
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… strings, - including `redact`, `ismatchingkey`, `can_convert_to_dict`, and - `recursive_key_operation`. - Added unit tests for the new functionalities to ensure correctness and reliability.
- Implemented redaction functions to obscure sensitive information in…
- Added recursive key operation and redaction for invocation params
|
Tests are passing locally. Codecov generally fails on PRs from forks because of auth, so disregard those failed checks. |
- code clarity and type safety. - Updated `can_convert_to_dict` and `recursive_key_operation` functions - to specify input and output types.
- Add type hints to function signatures in `common.py` for improved
- Updated docstring for clarity and improved input handling.
- Fix imports
CalebCourier
approved these changes
Jan 24, 2025
|
@abhishek9sharma Thanks again for your contribution! This will be part of our release next week. I also filed an issue concerning the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[redact]
ismatchingkey
can_convert_to_dict
recursive_key_operation
Fix for the bug. [bug] On turning on Arize tracing, the api_keys is being captured in Arize. #1213