Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making optional the 2FA parts of the config flow #195

Merged
merged 4 commits into from
Jan 17, 2024

Conversation

cantupaz
Copy link
Collaborator

I added an option to the setup form to make the 2FA parts optional. It doesn't seem to be needed, actually. But one day Securitas may decide to do something about it, so let's keep the code.

Did a bit of cleaning up typos as I was trying to understand the flow.

I do not have a yaml config for Securitas, so I didn't test if that part still works, so please check that it does work,

@guerrerotook
Copy link
Owner

Thanks for the PR @cantupaz, what do you mean that you don't have a yaml config to test this configuration? If the user has a yaml configuration that is automatically migrated to the config_flow and if the authentication fails because of the 2FA a new notification in Home Assistant will popup, so uses has two options, yaml or using the UI but at the end going to the same config entities store in HA.

Let me test this code in my development installation before I approve. I can run a debug my code and home assistant code at the same time.

@guerrerotook guerrerotook self-requested a review January 16, 2024 15:44
@guerrerotook guerrerotook added the enhancement New feature or request label Jan 16, 2024
@cantupaz cantupaz merged commit 9ea9ca5 into guerrerotook:main Jan 17, 2024
3 checks passed
@cantupaz
Copy link
Collaborator Author

Perdón. Se me pasó hacer el merge hasta ahora.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants