Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PERI alarms #197

Merged
merged 7 commits into from
Jan 23, 2024
Merged

Support for PERI alarms #197

merged 7 commits into from
Jan 23, 2024

Conversation

cantupaz
Copy link
Collaborator

to resolve this issue: #193

@guerrerotook
Copy link
Owner

Hey @cantupaz, is this ready for review?

@cantupaz
Copy link
Collaborator Author

Yes. Let me explain what I did.

In the API manager I tried to capture the possible states that the alarm can have (in securitas_direct_new_api/const.py). This is by looking at the securitas app and website, independent of HA. Then I map those states (like AlarmStates.total_armed) to the commands we need to send in the API ("ARM1" ). The mapping of states to commands can be different depending on having a peri alarm, so that's a parameter to the ApiManager.

In this version, the HA integration doesn't use the commands at all. It uses the AlarmStates and lets the ApiManager figure which mapping from states to commands it needs to use.

I changed the login form a little to add the option for peri and to make some text clearer (I hope). Same with the options form.

@guerrerotook guerrerotook linked an issue Jan 23, 2024 that may be closed by this pull request
@cantupaz cantupaz merged commit d4c47b6 into guerrerotook:main Jan 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adds support for PERI alarms
2 participants