Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3425. v1 - ScrollView is not clearing the background by duplicating views. #3428

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Apr 21, 2024

Fixes

Proposed Changes/Todos

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner April 21, 2024 23:09
@BDisp
Copy link
Collaborator Author

BDisp commented Apr 22, 2024

@dodexahedron ReSharper is always forcing this change 2b6627f every time I launch VS2022. Can this be merged? Thanks.

@tig tig merged commit 4b53807 into gui-cs:develop Apr 27, 2024
4 checks passed
@BDisp BDisp deleted the v1_scrollview-clear-fix_3425 branch April 27, 2024 13:51
@dodexahedron
Copy link
Collaborator

dodexahedron commented May 2, 2024

It's harmless to allow, typically. Those kinds of elements are so it knows how to handle things that may have changed.

The ones that have "Migration" in the name typically get added when something has either changed due to a R# version update or is different between your settings and the team settings.

If it's adding it, it likely needs to be there to avoid someone else's settings being altered improperly.

The other ones at the top of that change are actual settings changes.

@dodexahedron
Copy link
Collaborator

Also, if any change does result in material changes to how things get formatted for someone else, it's easy enough to remove the offending line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1 - ScrollView is not clearing the background by duplicating views.
3 participants