-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3691. Adds Popover
#3749
base: v2_develop
Are you sure you want to change the base?
Conversation
Refactored FindDeepestView
FWIW, here's the API in action (the prototype for the var fileMenuBarItem = new Shortcut
{
Title = "_File",
HelpText = "File Menu",
Key = Key.D0.WithAlt,
};
fileMenuBarItem.Accept += (sender, args) =>
{
var fileMenu = new Menuv2
{
Id = "fileMenu",
};
ConfigureMenu (fileMenu);
fileMenu.VisibleChanged += (sender, args) =>
{
if (Application.Popover == _popoverMenu && Application.Popover is { Visible: false })
{
Application.Popover?.Dispose ();
Application.Popover = null;
}
};
Application.Popover = fileMenu;
Rectangle screen = fileMenuBarItem.FrameToScreen ();
fileMenu.X = screen.X;
fileMenu.Y = screen.Y + screen.Height;
fileMenu.Visible = true;
}; Here's the entirety of the new API (on /// <summary>Gets or sets the Application Popover View.</summary>
/// <remarks>
/// <para>
/// To show or hide the Popover, set it's <see cref="View.Visible"/> property.
/// </para>
/// </remarks>
public static View? Popover |
Fixed a bunch more CM issues related ot unreliable unit tests. Updated config.json to include Glyphs.
I don't understand. TextView does know the cursor pos. I've used it to position the CM in this PR. I'm travelling today so can't send a video. Try it and let me know what you think. |
Nothing of this is working in your PR. You put a zig zag menus for what? To show that this will stopping working? |
This is a WIP. I will add the more advanced features as I progress. |
Need to fix more in gui-cs#3766 now.
Fixes
Popover
- A consistent way of enabling a Subview to popup outside of a View #3691Proposed Changes/Todos
View Experiments
the concept described inPopover
- A consistent way of enabling a Subview to popup outside of a View #3691 to prove concept.Bars
to show howContextMenu
andMenuBar
could utilizeContextMenu
usingMenuV2
- Initially no cascading menus for simplicityAutocompletePopup
Combobox
Future PRs
Menu
andMenuBar
usingBar
(aka finishMenuv2
Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)