Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3713 - TextField & TextView - When pressing right/left clear the selection instead of move tab #3776

Merged
merged 8 commits into from
Oct 11, 2024
Merged

Fixes #3713 - TextField & TextView - When pressing right/left clear the selection instead of move tab #3776

merged 8 commits into from
Oct 11, 2024

Conversation

tznind
Copy link
Collaborator

@tznind tznind commented Oct 6, 2024 •
edited
Loading

Fixes

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

BDisp
BDisp suggested changes Oct 6, 2024
View reviewed changes
Copy link
Collaborator

@BDisp BDisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some minor things. Thanks

Terminal.Gui/Views/TextField.cs Outdated Show resolved Hide resolved
UnitTests/Views/TextFieldTests.cs Show resolved Hide resolved
BDisp
BDisp suggested changes Oct 6, 2024
View reviewed changes
UnitTests/Views/TextFieldTests.cs Outdated Show resolved Hide resolved
@tznind tznind marked this pull request as ready for review October 6, 2024 10:28
@tznind tznind requested a review from tig as a code owner October 6, 2024 10:28
BDisp
BDisp suggested changes Oct 6, 2024
View reviewed changes
UnitTests/Views/TextViewTests.cs Outdated Show resolved Hide resolved
@tig tig changed the title Fixes #3713 - When pressing right/left clear the selection instead of move tab Fixes #3713 - TextField & TextView - When pressing right/left clear the selection instead of move tab Oct 6, 2024
@tig
Copy link
Collaborator

tig commented Oct 11, 2024

@tznind please fix the conflicts.

@tznind
Copy link
Collaborator Author

tznind commented Oct 11, 2024

@tznind please fix the conflicts.

Have fixed

@tig tig merged commit cc0d965 into gui-cs:v2_develop Oct 11, 2024
4 checks passed
BDisp pushed a commit to BDisp/Terminal.Gui that referenced this pull request Oct 13, 2024
@tznind @tig @BDisp
Fixes gui-cs#3713 - TextField & TextView - When pressing right/le…
409dac2 
…ft clear the selection instead of move tab (gui-cs#3776)

* When pressing right clear the selection instead of move tab - TextField

* Add tests and start on TextView

* Finish tests for TextView

* Fix typos

* typo fix x2

* Fix for Selecting being renamed IsSelecting

---------

Co-authored-by: Tig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BDisp BDisp BDisp approved these changes

@tig tig tig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arrow Right in TextField/TextView should not move tab if there is a selection
3 participants
@tznind @tig @BDisp