Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3029 - Refactors MouseEvent and APIs to simplify and make consistent #3797

Merged
merged 21 commits into from
Oct 15, 2024

Conversation

tig
Copy link
Collaborator

@tig tig commented Oct 15, 2024

Dependent on

Fixes

Proposed Changes/Todos

  • Clean up Application.Mouse.cs
  • Clean up View.Mouse.cs
  • Merge MouseEvent and MouseEventEventArgs into MouseEventArgs
  • Update API docs/conceptual docs

What this does NOT fix

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig requested review from BDisp and tznind October 15, 2024 13:52
@tig tig marked this pull request as ready for review October 15, 2024 13:53
@tig tig merged commit 0a108fa into gui-cs:v2_develop Oct 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor MouseEvent and MouseEventEventArgs to simplify
2 participants