Update dependency to 2329 #301
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test run is green in CI but CI only ran ~400 tests which is odd Full test run locally is: Test Run Failed. |
|
Looks like this is not the most recent nuget package, see gui-cs/Terminal.Gui#3779 Suspending for now while we work out what the upgrade path should be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial observations
Adding a
DateTimeFieldimplicitly adds a siblingPopupview too resulting in 2 views being added. Likely as a result ofPopover- A consistent way of enabling a Subview to popup outside of a View Terminal.Gui#3691 and/or Fixes #3750 -MouseEnter/LeaveTerminal.Gui#3751Keyboard navigation and accept in confirm dialog is broken:
Pressing Enter does nothing, neither does space or tab. Only clicking buttons triggers