Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove old neynar api call #1520

Merged
merged 3 commits into from
Oct 9, 2024
Merged

fix: remove old neynar api call #1520

merged 3 commits into from
Oct 9, 2024

Conversation

dominik-stumpf
Copy link
Contributor

@dominik-stumpf dominik-stumpf commented Oct 9, 2024

Objective

Until the new neynar endpoint is finished, remove the neynar call that causes error on profiles with farcaster
Use guild.xyz without subdomain for url when requesting neynar.

Investigation

Error was caused by having a real href swapped by the new neynar route handler (api/neynar), which is required by URL constructor

const neynarRequest = fcProfile && new URL(`${NEYNAR_BASE_URL}/user/bulk?fids=${fcProfile.fid}`, api)

discord reference

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
guild-xyz ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 8:51pm

Copy link
Contributor

@TomiOhl TomiOhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked about it irl, not that many changes & currently some pages are broken so let's merge it

@TomiOhl TomiOhl merged commit 1e1ed88 into main Oct 9, 2024
6 checks passed
@TomiOhl TomiOhl deleted the neyar-ssr-fetch-hotfix branch October 9, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants