For rspec, clear in the around block instead of the before block #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to hook order we clear on around instead of before. This is because if we clear in before, before runs AFTER around does and therefore overrides any redis based changes we make in the around hook. If we clear in around, we can make changes to redis in BOTH the around and before hooks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to hook order we clear on
aroundinstead ofbefore. This is because if we clear inbefore,beforeruns afterarounddoes and therefore overrides any redis based changes we make in the around hook.If we clear in
around, we can make changes to redis in both the around and before hooks!People may rely on the previous confusing behavior implicitly, so I recommend potentially making this a minor/major version change.