Propose adding Plane.isometric to built-in planes
#647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are a number of built-in planes like Plane.XY, YZ, front, top, etc. I propose adding a
Plane.isometricbuilt-in plane that will (1) allow aligning objects to the viewers isometric view direction (tested against OCP CAD Viewer and CQ-editor) (2) Provide access to a less trivial plane definition that could help improve robustness of unit tests (none of thePlane.isometricaxes align with the global XYZ axes). There may also be some benefits to the 2D exporters, since providing an easier-to-access isometric view direction could be helpful for e.g. "more intelligible" 2D representations of 3D objects.