Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isclose on all platforms to attempt to fix MacOS / arm64 test failure for new Wire.trim feature #679

Merged
merged 14 commits into from
Aug 30, 2024
Merged

isclose on all platforms to attempt to fix MacOS / arm64 test failure for new Wire.trim feature #679

merged 14 commits into from
Aug 30, 2024

Commits on Aug 29, 2024

  1. test_direct_api.py -> reenable test that fail(ed) on MacOS arm64

    @jdegenstein
    jdegenstein authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    7f8223b View commit details
    Browse the repository at this point in the history

  2. topology.py -> use math.isclose() to try and fix behavior on all plat… 

    …forms especially MacOS+arm64
    @jdegenstein
    jdegenstein authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    d337dcc View commit details
    Browse the repository at this point in the history

  3. topology.py -> Fix named parameter and try again

    @jdegenstein
    jdegenstein authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    734a526 View commit details
    Browse the repository at this point in the history

  4. topology.py -> loosen abs_tol from 1e-14 to TOLERANCE (currently 1e-6)

    @jdegenstein
    jdegenstein authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    674e09a View commit details
    Browse the repository at this point in the history

  5. topology.py

    @jdegenstein
    jdegenstein authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    40d5a0e View commit details
    Browse the repository at this point in the history

  6. topology.py -> add debugging prints

    @jdegenstein
    jdegenstein authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    8c132e2 View commit details
    Browse the repository at this point in the history

  7. test.yml -> don't capture output for all platforms pytest -rA

    @jdegenstein
    jdegenstein authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    7d82178 View commit details
    Browse the repository at this point in the history

  8. topology.py -> more isclose in Wire.trim

    @jdegenstein
    jdegenstein authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    5386a3a View commit details
    Browse the repository at this point in the history

  9. topology.py -> add def isclose_b with suitable defaults

    @jdegenstein
    jdegenstein authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    baa8055 View commit details
    Browse the repository at this point in the history

  10. operations_generic.py -> add dependency on isclose_b from topology.py

    @jdegenstein
    jdegenstein authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    d631d07 View commit details
    Browse the repository at this point in the history

  11. topology.py -> fix trim_to_length

    @jdegenstein
    jdegenstein authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    06ad867 View commit details
    Browse the repository at this point in the history

  12. test.yml -> undo temporary change for debugging

    @jdegenstein
    jdegenstein authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    8126bd9 View commit details
    Browse the repository at this point in the history

  13. topology.py -> simplify param_at_point again

    @jdegenstein
    jdegenstein authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    e1c649e View commit details
    Browse the repository at this point in the history

  14. topology.py -> use abs_tol=TOLERANCE in param_at_point again

    @jdegenstein
    jdegenstein authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    084d3cc View commit details
    Browse the repository at this point in the history