#104 Run tests for the user creating the PR

[filiphr]

Adding a step in the GitHub action to test the submission of the user submitting the PR

Fixes #104

@gunnarmorling please wait for merging, I want to also push some failures to see how it looks like.

cc @AlexanderYastrebov

[filiphr]

A failure would look like

and then if you go into details you'll see

[filiphr]

I've also added a check to validate that the file exists. If a file does not exists it will have an error like

[filiphr]

@gunnarmorling this is now ready for merging. I've removed the commits that were causing failures.

[AlexanderYastrebov]

I guess we can change this to echo "Validating $1 -- $sample" to make it a bit cleaner

[filiphr]

Sounds OK to me. I'll change it.

[filiphr]

I forgot to change this. I think we can merge without it, and we can change it later.

[AlexanderYastrebov]

I am not sure this will work for all submissions, e.g. some use sdk or graal

[filiphr]

Indeed it might not work. I'll see if we can use https://github.com/sdkman/sdkman-action/tree/main

[gunnarmorling]

Yeah, I think this would be good. Wanna add it to this PR?

[filiphr]

Was already working on it, but I am travelling today so a bit slow :)

[AlexanderYastrebov]

There is a related ticket #150

[AlexanderYastrebov]

I thin PR description fixes wrong ticket, should be #104

[filiphr]

I thin PR description fixes wrong ticket, should be #104

good point. I've updated that

[filiphr]

I've squashed all the commits and I've added SDKMAN as an action.

For this to work on the CI people will need to do something like:

source "$HOME/.sdkman/bin/sdkman-init.sh"
sdk install java 21.0.1-graal 1>&2
sdk use java 21.0.1-graal 1>&2

The sdk install is needed because the CI will not have the needed JDK. If the specified JDK is installed then sdk install is a noop (won't faill).

---

Aside from this approach, I have also been looking into an alternative. However, it would require a change in all scripts.

The calculate script can look like

function java_to_use() {
    echo "21.0.1-graal"
}

function run_submission() {
  JAVA_OPTS=""
  time java $JAVA_OPTS --class-path target/average-1.0.0-SNAPSHOT.jar dev.morling.onebrc.CalculateAverage_<username>
}

The java_to_use is optional and if omitted then the default one is used. We would then have a helper.sh which looks like

source $HOME/.sdkman/bin/sdkman-init.sh

function sdk_use_java() {
  if [ -z "$1" ]; then
    echo "Usage: sdk_use_java <candidate>"
    exit 1
  fi
  java_to_use="$1"
  sdk install java ${java_to_use} 1>&2
  sdk use java ${java_to_use} 1>&2
}

if [ -n "$(LC_ALL=C type -t java_to_use)" ] && [ "$(LC_ALL=C type -t java_to_use)" = function ]; then
  sdk_java=$(java_to_use)
  sdk_use_java ${sdk_java}
fi

java -version

the evaluate.sh will need to then have before the loop

source ${CALCULATE_FILE}
source ./helper.sh

and in the loop the diff would be

diff <(run_submission) ${sample%.txt}.out

Similar chnage would be needed for the evaluate.sh and we would most likelt need to add a run.sh that would then run the calculate as well.

Let me know what you think about this idea.

[gunnarmorling]

Could we somehow pre-install all the (currently) used distributions?

[gunnarmorling]

Could we somehow pre-install all the (currently) used distributions?

Any thoughts on this, @filiphr? Or should we close it for now?

[filiphr]

Yes we can do that. I've been away with a really bad internet connection. I'm back on Sunday, will be able to look into it then

[gunnarmorling]

Ok, closing for now. Thx for looking into this, @filiphr!

[gunnarmorling]

Gave this another try, see #535.