Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove nativewind #193

Merged
merged 3 commits into from
Feb 4, 2025
Merged

chore: remove nativewind #193

merged 3 commits into from
Feb 4, 2025

Conversation

gunnartorfis
Copy link
Owner

If we want to have full support for nativewind, we have to approach it better from scratch.

Summary

Closes #192

@gunnartorfis gunnartorfis requested review from ljukas and hyoban February 4, 2025 15:09
@gunnartorfis
Copy link
Owner Author

Requested review just in case you guys have time, no worries if you can't.

ljukas
ljukas approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@ljukas ljukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use nativewind aswell in my projects but I agree it should not be a peer dep here. Using just basic stylesheet is enough and makes the implementation simpler. Feels like a good removal to me

@gunnartorfis gunnartorfis merged commit 95ed730 into main Feb 4, 2025
5 checks passed
@gunnartorfis gunnartorfis deleted the chore/remove-nativewind branch February 4, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljukas ljukas ljukas approved these changes

@hyoban hyoban Awaiting requested review from hyoban

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop nativewind as a peer dep
2 participants
@gunnartorfis @ljukas