Adjust Creature sprite naming conventions #839
Merged
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was giving this some more thought and while I still think there is room for improvement regarding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Description - Adjust Creature sprite naming conventions
Fixes - Closes #777
Summary
Updated Creature Sprite state to MOVE from WALK to make it more generic.
Additional thoughts
For the issue #777, as per the present implementation, I didn't find any place where state and direction is calculated by splitting the sprite name at '-' characters. As per my understanding, sprite name is calculated from state or direction to prepare the name of the image. Therefore, in my opinion, the 2nd point most probably is not relevant as per the current implementation. Please correct me if I am wrong. Thanks so much!