Add support for D inputs on DSP #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gussmith23
reviewed
May 25, 2023
|
I nearly lost this PR! Currently working on finally merging this so that @vcanumalla can use it in eval. |
See #288. This is a hack around that. This will quickly be overwritten, i'm sure, though. Next time I reimport these semantics, I'm sure I'll forget to change this back.
Why wasn't this a constant in the first place?
This was seemingly blowing up synthesis
SummaryAfter merging in the existing changes on main, I started having some problems with solver scaling on this PR. I spent a lot of time figuring it out; in the end, it ended up being a matter of just narrowing down the search space by restricting the concrete and symbolic variables. We need to spend some time (ideally with a solver expert) in figuring out which solver to use, and what flags to use with it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends DSP primitive interface to support another input, D
Adds integration test for a module which Vivado (Vivado v2021.2 (64-bit), SW Build 3367213 on Tue Oct 19 02:47:39 MDT 2021, IP Build 3369179 on Thu Oct 21 08:25:16 MDT 2021) fails
Adds a script for Verilator testing
Fix hardcoded path in integration test; add environment variable for
lakeroad-privateand check that it is setFix Verilator portability issues