Cancel concurrent CI runs for branches other than main #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gussmith23
requested changes
Jul 26, 2023
| @@ -18,6 +18,11 @@ env: | |||
| # Can't use ${{ env.REGISTRY }} here, but would like to, so that we' don't | |||
| # repeat ghcr.io. | |||
| IMAGE_TAG: ghcr.io/${{ github.repository }}:sha-${{ github.sha }} | |||
|
|
|||
| concurrency: | |||
| # Cancel in-progress runs for branches other than main | |||
There was a problem hiding this comment.
I don't think this comment is exactly correct. This doesn't necessarily ignore the main branch. It just uses a different group ID if the branch is main (it uses run_id if the branch is main). This basically means that this workflow won't get canceled for pushes to main, which is fine for our purposes.
Can you add a reference to the source where you took the code from?
https://www.meziantou.net/how-to-cancel-github-workflows-when-pushing-new-commits-on-a-branch.htm
Thank you!
There was a problem hiding this comment.
To be clear, please:
- Update the comment to reflect what the concurrency group actually does
- Add a reference to the link
|
Hello @gussmith23 , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #298