-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for arbitrary width dsp operations #363
Draft
vcanumalla
wants to merge
19
commits into
main
Choose a base branch
from
vcanumalla/parallel-dsp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcanumalla
force-pushed
the
vcanumalla/parallel-dsp
branch
from
October 19, 2023 23:00
069b6ff
to
2ece52d
Compare
…nto vcanumalla/parallel-dsp
Looks like you need to resolve merge conflicts on this! |
gussmith23
added a commit
that referenced
this pull request
Sep 7, 2024
gussmith23
added a commit
that referenced
this pull request
Sep 17, 2024
This is something that @vcanumalla started working on almost a year ago as part of #363. While I may or may not get around to merging that whole PR, at the very least, this component of that PR is very useful, so I'm going to try to get it merged. --------- Co-authored-by: Vishal Canumalla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for arbitrary size DSP operations (for example, a 36 bit addition).
I don't know whether wide multiplication is going to be feasible, especially before deadline, but something to think about for the future.
This PR does not add unit tests to
racket/sketches.rkt
but does add integration tests.