CMAKE: Debug Windows Build Fixes #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s working properly. Minor cleanup on modern style. Executables now get the CMAKE_DEBUG_POSTFIX again.
gwaldron
pushed a commit
to VTMAK/osgearth
that referenced
this pull request
May 22, 2024
…s working properly. Minor cleanup on modern style. Executables now get the CMAKE_DEBUG_POSTFIX again. (gwaldron#2543)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several minor changes to fix debug Windows builds:
OE:SILVERLININGandOE::TRITONimported libraries with properly set debug librariesCMAKE_CONFIG_POSTFIXapplied again, preventing a debug make install executable from overwriting a release mode executable of same nameBefore this, debug builds of osgEarth failed due to linking to release mode SilverLining and Triton on Windows.
Tested on Windows MSVC 2022 and Linux EL8 gcc 12.2.1.