Purge fullinj / injfull analyses #4420
Conversation
GarethCabournDavies
force-pushed
the
purge_inj_inclusive
branch
from
92916b5
to
c369a76
Compare
|
|
||
| # Indicate that inclusive IFAR is not calculated | ||
| f['foreground/ifar'] = numpy.array([]) | ||
| f['foreground/fap'] = numpy.array([]) |
There was a problem hiding this comment.
I would be in favour of not adding empty arrays into the coinc files and just removing these lines (and in sngls_statmap). Unless it serves a specific purpose??
There was a problem hiding this comment.
The reason for this is intended to be that this can be used to indicate that the inclusive IFAR is specifically not calculated. If there is no dataset, that could indicate an error/bug, but a specifically empty dataset implies that it was done on purpose (we could alternatively use all zero/NaN/inf values)
There was a problem hiding this comment.
I guess I see it the other way. An empty column to me indicates an error/bug more than the column not existing. And purging something means that it never existed, and it never will exist, so I should never look for it.
GarethCabournDavies
force-pushed
the
purge_inj_inclusive
branch
from
c369a76
to
c4bba71
Compare
* Purge fullinj / injfull analyses * remove unrelated change * Actually purge * delete del deletion * foreground_time may not be [present
* Purge fullinj / injfull analyses * remove unrelated change * Actually purge * delete del deletion * foreground_time may not be [present
* Purge fullinj / injfull analyses * remove unrelated change * Actually purge * delete del deletion * foreground_time may not be [present
Injections do not have inclusive IFAR / FAP calculated, so we can ignore the datasets.
Why?:
Proposed solution:
Note that I think we may be able to consolidate the statmap / statmap_inj jobs in the near future because of this change, but this isn't done here.