Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically make files for comprehensive offline gracedb uploads #4438
Automatically make files for comprehensive offline gracedb uploads #4438
Changes from all commits
0534ec9
e65f24b
b0508ec
b6066bf
64ecff2
7ddf5cc
c3e7be2
ece1285
b3a8d2c
a31f0ba
6679f25
2e12d21
af852aa
97e5cbf
c1386d1
e997ee7
d23d4ff
5b84ed5
f29afc2
292d494
75ab141
76603c7
3e77ee8
b0832de
f2bb680
465fefe
fff46e7
7e09357
43e1b61
f406d72
3050449
7256f9a
a2a170d
0b5c326
ab77a6d
46dacb8
340f9b9
fea78f3
4d27e15
019addb
71f02ed
13ce612
5086f5b
ea0af69
c07c3bc
38fe661
639d968
5c2cece
b811a54
9307200
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we including "subthreshold" detectors here? E.g. how would the single inspiral table for a L1-only trigger with observing-mode H1 look like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not including subthreshold detectors here, this is inherited from the pycbc_page_foreground output, so does not have this info added. I'm not sure whether we'd want that though or not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one from the github example run, and have uploaded to https://gracedb-playground.ligo.org/events/G1268054/view/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I suspect we do need the single inspiral entries to be present in order for BAYESTAR to use the subthreshold detectors, but let's keep things as they are for now. We can fix that with a later PR if needed.