-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live cleanup combine single fits #4450
Merged
titodalcanton
merged 7 commits into
gwastro:master
from
titodalcanton:live_cleanup_combine_single_fits
Aug 7, 2023
Merged
Live cleanup combine single fits #4450
titodalcanton
merged 7 commits into
gwastro:master
from
titodalcanton:live_cleanup_combine_single_fits
Aug 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarethCabournDavies
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this - I think some of these unused variables were from before the code was separated for combining / plotting, so thanks for that. One (very) minor suggestion, but this looks good to go
PRAVEEN-mnl
pushed a commit
to PRAVEEN-mnl/pycbc
that referenced
this pull request
Nov 3, 2023
* Docstring * Remove unused variables * Simplify loops/ifs * Whitespace * Logging tweaks * Unnecessary f-strings * Gareth's suggestion
titodalcanton
added a commit
to titodalcanton/pycbc
that referenced
this pull request
Jan 16, 2024
* Docstring * Remove unused variables * Simplify loops/ifs * Whitespace * Logging tweaks * Unnecessary f-strings * Gareth's suggestion
bhooshan-gadre
pushed a commit
to bhooshan-gadre/pycbc
that referenced
this pull request
Mar 4, 2024
* Docstring * Remove unused variables * Simplify loops/ifs * Whitespace * Logging tweaks * Unnecessary f-strings * Gareth's suggestion
acorreia61201
pushed a commit
to acorreia61201/pycbc
that referenced
this pull request
Apr 4, 2024
* Docstring * Remove unused variables * Simplify loops/ifs * Whitespace * Logging tweaks * Unnecessary f-strings * Gareth's suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup I thought about when reviewing #4449. I broke the change down into a few commits to make checking easier if needed.