Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional waveform and detector library examples #4456

Merged
merged 4 commits into from
Aug 9, 2023

Conversation

ahnitz
Copy link
Member

@ahnitz ahnitz commented Aug 8, 2023

This adds an addition waveform example showing how to select higher order modes and also adds in the custom waveform example to the library waveform page as well.

This also adds in an example of adding a custom detector in the library examples, both through the api and through a config file.

@ahnitz
Copy link
Member Author

ahnitz commented Aug 8, 2023

@ahnitz ahnitz requested review from WuShichao, titodalcanton and spxiwh and removed request for WuShichao and titodalcanton August 8, 2023 16:56
Copy link
Contributor

@spxiwh spxiwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested, happy to merge when ready. Thanks for doing this!

:show_shadows:
:show_captions_below:

.. figure:: https://collincapano.com/wp-content/uploads/2020/02/posterior3d-gw150914_masses-e1581860222179.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mild preference for having this hosted under pycbc.org.

examples/detector/ant.py Outdated Show resolved Hide resolved
examples/waveform/higher_modes.py Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
docs/index.rst Show resolved Hide resolved
@ahnitz ahnitz merged commit b711ca3 into gwastro:master Aug 9, 2023
36 checks passed
PRAVEEN-mnl pushed a commit to PRAVEEN-mnl/pycbc that referenced this pull request Nov 3, 2023
* add waveform and detector examples

* add coursel to highlight pycbc features

* fixes suggested by Ian
bhooshan-gadre pushed a commit to bhooshan-gadre/pycbc that referenced this pull request Mar 4, 2024
* add waveform and detector examples

* add coursel to highlight pycbc features

* fixes suggested by Ian
acorreia61201 pushed a commit to acorreia61201/pycbc that referenced this pull request Apr 4, 2024
* add waveform and detector examples

* add coursel to highlight pycbc features

* fixes suggested by Ian
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants