Enforce pygrb_efficiency subsections #4909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iguration file and insert back a line previously delete unintentionally
spxiwh
approved these changes
Oct 15, 2024
| err_msg += "corresponding [pygrb_efficiency] subsection. " | ||
| err_msg += "[injections] subsections found: %s. " | ||
| err_msg += "[pygrb_efficiency] subsections found: %s. " | ||
| logging.error(err_msg, inj_sets, eff_secs) |
There was a problem hiding this comment.
Hmm, there might be use cases where these subsections wouldn't be needed (e.g. running only one injection set, or just running a NS injection set ... maybe some new theory proves next year that NSBH GRBs definitely don't exist), but if it's better to enforce this, I won't object
Enforcing the two lists be equal is possibly not what you want, there could be other subsections in efficiency that are not injection names. I think you really want to check that inj_sets is a subset of eff_secs.
if set(inj_sets).issubset(eff_secs):
There was a problem hiding this comment.
Okay, I see your point. I may want to make more efficiency plot versions, so I need at least enough eff_secs to cover the inj_sets. I will make this change shortly.
…subsection in the configuration file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pygrb_efficiencysubsection in the config file for each injection set, i.e.[injections]subsection.pygrb_efficiencyplots.Standard information about the request
This is a: bug fix. Prior to this fix,
pygrb_efficiencywas using a single value of lower/upper distance values, regardless of the injection set.This change affects: PyGRB
This change changes: result presentation plotting and scientific output
This change was tested by rerunning the results generation of a GRB analysis here. Note that the previous version of plots in this section was "jagged".