Support date shortcuts; see issue #13 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Timezone jl introduces Z / z as DateTime character this was misinterpreted. See https://juliatime.github.io/TimeZones.jl/dev/conversions/#Parsing-strings
gwehrle
force-pushed
the
date-shortcut
branch
from
7f90f7f to
32150ec
Compare
kaat0
commented
Nov 27, 2024
|
I fixed the tests 🎉 I'll add some tests for the new function soon. |
|
I just saw that in Overpass turbo time calculation is done with constants of seconds. This means for durations like months or years this could lead to different behaviour. I still would stick to the current behaviour in this PR, as this is the correct way. But it should be added to documentation. |
gwehrle
force-pushed
the
date-shortcut
branch
from
9360657 to
813fbb5
Compare
gwehrle
force-pushed
the
date-shortcut
branch
from
541a2b8 to
d1653e1
Compare
|
All tests are done. For me this feature is ready to merge. |
|
Okay there are still two todos:
|
gwehrle
force-pushed
the
date-shortcut
branch
from
8ba5aae to
315a244
Compare
gwehrle
force-pushed
the
date-shortcut
branch
from
315a244 to
f42a54f
Compare
|
@kaat0 Thank you a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are currently missing and help is welcome.