Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addition of CODEOWNERS #127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

addition of CODEOWNERS #127

wants to merge 1 commit into from
+1 −0

Conversation

gwutrexl
Copy link
Contributor

Add a CODEOWNERS File with a catchall for this repository.

  • best practice
  • don't want to miss any future pull requests

codeowners docs

@gwutrexl
addition of CODEOWNERS
bb20071 
- best practice
- don't want to miss pull requests
@gwutrexl gwutrexl requested a review from a team April 23, 2024 18:54
@gwutrexl gwutrexl requested review from ghfields, jotto75, mandradeg and wesh44 and removed request for a team May 6, 2024 16:57
@ghfields
Copy link

ghfields commented May 6, 2024

I see you have this in the root of the repo. Would it be cleaner to have it in the .github/ folder?
https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-file-location

gwutrexl
gwutrexl commented Jul 9, 2024
View reviewed changes
Copy link
Contributor Author

@gwutrexl gwutrexl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe, I think either work. but as this is a public repo, I don't mind the group name being exposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghfields ghfields Awaiting requested review from ghfields

@jotto75 jotto75 Awaiting requested review from jotto75

@mandradeg mandradeg Awaiting requested review from mandradeg

@wesh44 wesh44 Awaiting requested review from wesh44

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gwutrexl @ghfields