Pin SciPy to <1.12 for now because of pyhht #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyhht imports `angle` from SciPy, which since 1.12.0 should be imported from NumPy. A fix was committed to pyhht, but a package with the fix is yet to be released. Pinning a Git release with an existing PyPI package can be tricky so this seems the best solution at this moment. Ref: jaidevd/pyhht@4ac9aaf
kerberizer
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyhht imports
anglefrom SciPy, which since 1.12.0 should be imported from NumPy. A fix was committed to pyhht, but a package with the fix is yet to be released. Pinning a Git release with an existing PyPI package can be tricky so this seems the best solution at this moment.Ref: jaidevd/pyhht@4ac9aaf