Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skewed profiles; Extend Ne reference data #190

Merged
merged 7 commits into from
Feb 2, 2025
Merged

Add skewed profiles; Extend Ne reference data #190

merged 7 commits into from
Feb 2, 2025

Conversation

georgievgeorgi
Copy link
Contributor

No description provided.

@georgievgeorgi georgievgeorgi force-pushed the fit_peaks branch 2 times, most recently from e600520 to b2a805c Compare November 19, 2024 20:41
@georgievgeorgi
Copy link
Contributor Author

the problem is with tests/protocols/test_calibrationmodel.py::test_laser_zeroing which seems to be fixed in #192

Copy link

github-actions bot commented Nov 26, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/ramanchada2/misc
  constants.py
  src/ramanchada2/misc/utils
  argmin2d.py
  poly_params.py 5-16, 20-22, 37-39
  rough_poly2_calibration.py 13-41, 45-52
  significant_peaks.py 5-10, 14-16
  src/ramanchada2/protocols
  calib_ne_si_argmin2d_iter_gg.py 32-35, 84, 120, 126
  src/ramanchada2/spectrum/calibration
  by_deltas.py 229, 280-287, 291-295, 329, 336, 356-362
  src/ramanchada2/spectrum/creators
  from_delta_lines.py
  src/ramanchada2/spectrum/peaks
  fit_peaks.py 57-62, 65-69
  tests/peak
  test_find_peaks.py
  tests/protocols
  test_calibrationmodel.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@vedina vedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@kerberizer kerberizer merged commit e82dbbf into main Feb 2, 2025
5 checks passed
@kerberizer kerberizer deleted the fit_peaks branch February 2, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants