Drop support for Python 3.8 (#141)

* Drop support for Python 3.8

* Update GitHub Action versions

* Update and run pre-commit and hooks

* Do not use No Content status code when testing responses with bodies

* Remove redundant function

This kind of string/bytes handling is no longer necessary since pook
v2.0.0 where all bodies are handled as bytes, and converted at the
edges. Internal library functions do not need to handle non-string
bodies.

* Update versions of libraries used for testing

* Update History.rst

.github/workflows/ci_cd.yml

@@ -9,9 +9,6 @@ on:
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
-  # Don't continue building images for a PR if the PR is updated quickly
-  # For other workflows, allow them to complete and just block on them. This
-  # ensures deployments in particular to happen in series rather than parallel.
   cancel-in-progress: ${{ github.event_name == 'pull_request' }}
 
 jobs:
@@ -26,7 +23,7 @@ jobs:
           fetch-depth: 0
 
       - name: Setup Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: '3.12'
           cache: 'pip'
@@ -48,7 +45,7 @@ jobs:
           fetch-depth: 0
 
       - name: Setup Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: '3.12'
           cache: 'pip'
@@ -67,7 +64,7 @@ jobs:
 
   test:
     name: test on ${{ matrix.py }}
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
@@ -77,16 +74,15 @@ jobs:
           - '3.11'
           - '3.10'
           - '3.9'
-          - '3.8'
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
       - name: Setup Python for test ${{ matrix.py }}
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.py }}
           cache: pip

.pre-commit-config.yaml

@@ -1,6 +1,6 @@
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.5.0
+    rev: v5.0.0
     hooks:
       - id: trailing-whitespace
         args: [--markdown-linebreak-ext=md]
@@ -21,7 +21,7 @@ repos:
       - id: requirements-txt-fixer
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.1.9
+    rev: v0.6.9
     hooks:
       - id: ruff
         args: [--fix]

History.rst

@@ -1,6 +1,11 @@
 History
 =======
 
+v2.1.0 / 2024-10-08
+-------------------------
+
+  * Drop support for Python 3.8 (it is EOL 2024-10-07)
+
 v2.0.1 / 2024-10-08
 -------------------------
 

README.rst

@@ -31,7 +31,7 @@ Features
 -  Supports third-party mocking engines, such as `mocket`_.
 -  Fits good for painless test doubles.
 -  Does not support WebSocket traffic mocking.
--  Works with +3.8 (including PyPy).
+-  Works with +3.9 (including PyPy).
 -  Dependency-less: just 3 small dependencies for JSONSchema, XML tree comparison, and URL parsing.
 
 

docs/conf.py

@@ -22,7 +22,7 @@
 sys.path.insert(0, os.path.abspath(".."))
 
 import pook  # noqa
-import sphinx_rtd_theme  # noqa
+import sphinx_rtd_theme
 
 # -- General configuration ------------------------------------------------
 

examples/chainable_api.py

@@ -1,7 +1,8 @@
 import json
-import pook
+
 import requests
 
+import pook
 
 # Enable mock engine
 pook.on()
@@ -11,7 +12,7 @@
     .json({"foo": "bar"})
     .type("json")
     .header("Client", "requests")
-    .reply(204)
+    .reply(201)
     .headers({"server": "pook"})
     .json({"error": "simulated"})
 )

examples/context_manager.py

@@ -1,6 +1,6 @@
-import pook
 import requests
 
+import pook
 
 with pook.api.context():
     pook.get(

examples/decorator_activate.py

@@ -1,6 +1,7 @@
-import pook
 import requests
 
+import pook
+
 
 @pook.on
 def run():

examples/decorators.py

@@ -1,6 +1,7 @@
-import pook
 import requests
 
+import pook
+
 
 @pook.get("http://httpbin.org/status/500", reply=204)
 @pook.get("http://httpbin.org/status/400", reply=200, persist=True)

examples/http_client_native.py

@@ -1,6 +1,6 @@
 import http.client
-import pook
 
+import pook
 
 # Enable mock engine
 pook.on()

examples/json_matching.py

@@ -1,14 +1,16 @@
 import json
-import pook
+
 import requests
 
+import pook
+
 # Enable mock engine
 pook.on()
 
 (
     pook.post("httpbin.org/post")
     .json({"foo": "bar"})
-    .reply(204)
+    .reply(201)
     .json({"error": "simulated"})
 )
 

examples/json_schema.py

@@ -1,7 +1,8 @@
 import json
-import pook
+
 import requests
 
+import pook
 
 schema = {
     "type": "object",
@@ -16,7 +17,7 @@
 (
     pook.post("httpbin.org/post")
     .jsonschema(schema)
-    .reply(204)
+    .reply(201)
     .json({"error": "simulated"})
 )
 

examples/match_callback.py

@@ -1,6 +1,7 @@
-import pook
 import requests
 
+import pook
+
 
 def on_match(request, mock):
     print("On match:", request, mock)

examples/mock_context_manager.py

@@ -1,6 +1,6 @@
-import pook
 import requests
 
+import pook
 
 # Define a new mock that will be only active within the context manager
 with pook.get(

examples/mocket_example.py

@@ -1,10 +1,11 @@
 # Be sure you have `mocket` installed:
 # $ pip install mocket
 
-import pook
 import requests
 from mocket.plugins.pook_mock_engine import MocketEngine
 
+import pook
+
 # Use mocket library as underlying mock engine
 pook.set_mock_engine(MocketEngine)
 

examples/network_mode.py

@@ -1,6 +1,6 @@
-import pook
 import requests
 
+import pook
 
 # Enable mock engine
 pook.on()
@@ -10,7 +10,7 @@
 
 (
     pook.get("httpbin.org/headers")
-    .reply(204)
+    .reply(201)
     .headers({"server": "pook"})
     .json({"error": "simulated"})
 )

examples/network_mode_httpx.py

@@ -1,6 +1,6 @@
-import pook
 import httpx
 
+import pook
 
 # Enable mock engine
 pook.on()
@@ -10,7 +10,7 @@
 
 (
     pook.get("httpbin.org/headers")
-    .reply(204)
+    .reply(201)
     .headers({"server": "pook"})
     .json({"error": "simulated"})
 )

examples/persistent_mock.py

@@ -1,6 +1,6 @@
-import pook
 import requests
 
+import pook
 
 # Enable mock engine
 pook.on()

examples/pytest_example.py

@@ -1,7 +1,8 @@
-import pook
 import pytest
 import requests
 
+import pook
+
 
 @pook.activate
 def test_simple_pook_request():

examples/query_params_matching.py

@@ -1,19 +1,20 @@
-import pook
 import requests
 
+import pook
+
 # Enable mock engine
 pook.on()
 
 (
     pook.get("httpbin.org/get")
     .params({"foo": "bar"})
-    .reply(204)
+    .reply(201)
     .json({"error": "simulated"})
 )
 
 res = requests.get("http://httpbin.org/get", params={"foo": "bar"})
 
-assert res.status_code == 204
+assert res.status_code == 201
 assert res.json() == {"error": "simulated"}
 assert pook.isdone()
 assert pook.pending_mocks() == []

examples/regex.py

@@ -1,6 +1,6 @@
-import pook
 import requests
 
+import pook
 
 # Enable mock engine
 pook.on()

examples/requests_client.py

@@ -1,6 +1,6 @@
-import pook
 import requests
 
+import pook
 
 # Enable mock engine
 pook.on()

examples/simulated_error.py

@@ -1,6 +1,6 @@
-import pook
 import requests
 
+import pook
 
 # Enable mock engine
 pook.on()

examples/time_ttl_mock.py

@@ -1,6 +1,6 @@
-import pook
 import requests
 
+import pook
 
 # Enable mock engine
 pook.on()

examples/unittest_example.py

@@ -1,7 +1,9 @@
-import pook
 import unittest
+
 import requests
 
+import pook
+
 
 class TestUnitTestEngine(unittest.TestCase):
     @pook.on

examples/urllib3_chunked_response.py

@@ -1,6 +1,6 @@
-import pook
 import urllib3
 
+import pook
 
 # Mock HTTP traffic only in the given context
 with pook.use():

examples/urllib3_client.py

@@ -1,6 +1,6 @@
-import pook
 import urllib3
 
+import pook
 
 # Mock HTTP traffic only in the given context
 with pook.use():