call pook.off in the end of pook.activate wrapper function #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Thank you for the issue and PR @shift0965 🙏 Can you add a unit test for this fix? You will also need to update activate_async to fix the same problem for async tests: https://github.com/h2non/pook/blob/master/src/pook/activate_async.py#L26
We'll need a unit test for each as well. If you would like guidance on adding the tests, let me know and I can give some pointers.
|
Thank you for you feedback! I just added test cases for each scenario and let me know if there are any further adjustments you like me to make. |
sarayourfriend
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PL is for this issue