Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aiohttp session match #157

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Fix aiohttp session match #157

merged 5 commits into from
Nov 20, 2024

Conversation

sarayourfriend
Copy link
Collaborator

@sarayourfriend sarayourfriend commented Nov 20, 2024 •
edited
Loading

Description

Fixes #156

Also fixed a few aiohttp edge cases:

  • If the client session has a special response class set, pook will now use that for the mocked response.
  • Pook now uses aiohttp's named tuple to set the version on the response rather than an anonymous tuple.

PR Checklist

  • I've added tests for any code changes
  • I've documented any new features

@sarayourfriend sarayourfriend force-pushed the fix-aiohttp-session-match branch from a7ea719 to 0a0412f Compare November 20, 2024 23:42
@sarayourfriend sarayourfriend merged commit 94dede1 into master Nov 20, 2024
9 checks passed
@sarayourfriend sarayourfriend deleted the fix-aiohttp-session-match branch November 20, 2024 23:44
@sarayourfriend sarayourfriend mentioned this pull request Nov 24, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aiohttp mocking does not respect ClientSession base_url or headers passed in constructor
1 participant
@sarayourfriend