Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI/CD #11

Merged
merged 29 commits into from
Jun 14, 2023
Merged

CI/CD #11

merged 29 commits into from
Jun 14, 2023

Conversation

Himura2la
Copy link
Collaborator

@Himura2la Himura2la commented May 28, 2023 •
edited
Loading

@Himura2la Himura2la changed the title CI/CD Draft: CI/CD May 28, 2023
@Himura2la Himura2la marked this pull request as draft May 28, 2023 08:43
@Himura2la Himura2la changed the title Draft: CI/CD CI/CD May 28, 2023
@Himura2la Himura2la force-pushed the ci-cd branch 4 times, most recently from bb8529a to 2a3c539 Compare May 29, 2023 19:40
@Himura2la Himura2la force-pushed the ci-cd branch 2 times, most recently from 8fb179a to d0e1239 Compare June 9, 2023 20:44
@Himura2la Himura2la marked this pull request as ready for review June 11, 2023 10:12
@Himura2la Himura2la requested review from tectonick and ezhevita June 11, 2023 10:44
@Himura2la Himura2la self-assigned this Jun 11, 2023
ezhevita
ezhevita reviewed Jun 11, 2023
View reviewed changes
Copy link

@ezhevita ezhevita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also: how will ansible roles get deployed?

.github/workflows/app-deployment.yml Show resolved Hide resolved
config/default.json Outdated Show resolved Hide resolved
deploy/Containerfile Outdated Show resolved Hide resolved
deploy/inventory.yml Outdated Show resolved Hide resolved
deploy/roles/dockerized_service/tasks/main.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@Himura2la
Copy link
Collaborator Author

Himura2la commented Jun 11, 2023 •
edited
Loading

also: how will ansible roles get deployed?

@ezhevita, From local workstations. But deploying AWX or Semaphore is a good idea. I also can add a GH Action for running playbooks, but there's no use in it IMHO.

tectonick
tectonick approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@tectonick tectonick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tectonick tectonick merged commit 3030e3b into main Jun 14, 2023
@tectonick tectonick deleted the ci-cd branch September 23, 2023 14:08
@tectonick tectonick restored the ci-cd branch September 23, 2023 14:08
@tectonick tectonick deleted the ci-cd branch September 23, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezhevita ezhevita ezhevita left review comments

@tectonick tectonick tectonick approved these changes

Assignees

@Himura2la Himura2la

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Himura2la @tectonick @ezhevita