Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1828 implment designs for email template #1832

Merged
merged 6 commits into from
Oct 11, 2024
Merged

1828 implment designs for email template #1832

merged 6 commits into from
Oct 11, 2024

Conversation

Brandoncyu
Copy link
Member

@Brandoncyu Brandoncyu commented Sep 24, 2024 •
edited
Loading

Fixes #1828

  • Up to date with main branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@Brandoncyu Brandoncyu mentioned this pull request Sep 24, 2024
Closed
6 tasks
ryanfchase
ryanfchase requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@ryanfchase ryanfchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on how to reference images. We'll need to reference the "hosted" image.

templates/contact-us.html Outdated Show resolved Hide resolved
templates/contact-us.html Outdated Show resolved Hide resolved
@Brandoncyu
Copy link
Member Author

Made adjustments. New template works:
image

@ryanfchase
Copy link
Member

I am seeing a weird black line in your image. I'm not seeing anything in the code that would warrant that. I've tested your code and the html seems to be rendering as expected. Leaving my screenshot so that we can have design lead review.

image

@Brandoncyu
Copy link
Member Author

I've tried it again and I can't seem to repro the black line in the image. Perhaps it was a copy paste issue for the photo?

image

@ryanfchase
Copy link
Member

I've tried it again and I can't seem to repro the black line in the image. Perhaps it was a copy paste issue for the photo?

Sounds good! Thanks for confirming. This ticket will still await design lead review. Marking it in our agenda for tonight.

ryanfchase
ryanfchase approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@ryanfchase ryanfchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, approved 👍

ryanfchase
ryanfchase approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@ryanfchase ryanfchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Font family was changed to Arial. Confirmed the font is sans-serif. Feedback has been implemented, this is approved and ready to merge.

@Brandoncyu Brandoncyu merged commit 24b0766 into main Oct 11, 2024
@Brandoncyu Brandoncyu deleted the 1828-implement-designs-for-email-template branch October 11, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanfchase ryanfchase ryanfchase approved these changes

Assignees

@ryanfchase ryanfchase

@traycn traycn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement designs for email template
3 participants
@Brandoncyu @ryanfchase @traycn