Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated Checkin Button to Material UI #1725

Merged
merged 4 commits into from
Mar 4, 2025
Merged

Conversation

ntrehan
Copy link
Member

@ntrehan ntrehan commented Aug 10, 2024

Fixes #1683

What changes did you make and why did you make them ?

Changed from Default react components to Material UI in CheckinButtons.js

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ntrehan-1683 development
git pull https://github.com/ntrehan/VRMS.git 1683

@JackHaeg JackHaeg requested a review from trillium August 15, 2024 19:02
@JackHaeg
Copy link
Member

JackHaeg commented Aug 15, 2024

@ntrehan & @trillium - looks like the updated MUI buttons used in the above screenshots are no longer viewable to the user (no outline viewable on the button, only button text is viewable which may impact clear usability / understanding that this is an interactive element for the user).

I might recommend using the following MUI component if we want to replicate a similar style to the old button layout: <Button variant="outlined">Outlined</Button>. See more here: https://mui.com/material-ui/react-button/

That said, I'd check with @trillium on this first to get his thoughts :)

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JackHaeg
Copy link
Member

@trillium Do you think we should change this to an outlined button, like I mentioned in my previous comment before we go ahead and merge?

@JackHaeg
Copy link
Member

@ntrehan, confirmed with @trillium that we should change the button style to contain borders - please make the updates according to the above comment: #1725 (comment)

@ntrehan
Copy link
Member Author

ntrehan commented Mar 3, 2025

Hi @JackHaeg , @trillium
I have made the required changes as pointed out by jack and have also taken the liberty to add a small margin to avoid clumping of the outlined buttons
image
Please let me know if this is okay or any further changes are required

@JackHaeg
Copy link
Member

JackHaeg commented Mar 4, 2025

@trillium agrees with the changes above. Any team member can review this issue.

@trillium trillium merged commit d3c77e8 into hackforla:development Mar 4, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HTML components to MUI: ./src/components/presentational/CheckInButtons.js
3 participants