-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated Checkin Button to Material UI #1725
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
@ntrehan & @trillium - looks like the updated MUI buttons used in the above screenshots are no longer viewable to the user (no outline viewable on the button, only button text is viewable which may impact clear usability / understanding that this is an interactive element for the user). I might recommend using the following MUI component if we want to replicate a similar style to the old button layout: That said, I'd check with @trillium on this first to get his thoughts :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@trillium Do you think we should change this to an outlined button, like I mentioned in my previous comment before we go ahead and merge? |
@ntrehan, confirmed with @trillium that we should change the button style to contain borders - please make the updates according to the above comment: #1725 (comment) |
@trillium agrees with the changes above. Any team member can review this issue. |
Fixes #1683
What changes did you make and why did you make them ?
Changed from Default react components to Material UI in CheckinButtons.js
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied