Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1244 Checkbox Testing #1579

Merged
merged 9 commits into from
Sep 30, 2024
Merged

1244 Checkbox Testing #1579

merged 9 commits into from
Sep 30, 2024

Conversation

eburdekin
Copy link
Member

@eburdekin eburdekin commented Sep 27, 2024

Fixes #1244

Changes made:

Added tests for the following:

  • Checkbox sets up correctly
    • Checkbox renders
    • renders correct initial state
  • Checkbox functions correctly
    • clicking checkbox changes state
    • clicking checkbox does NOT change state of other checkboxes (multi-select is possible)
  • Checkbox props are passed correctly
    • id passes correctly
    • label passes correctly
  • Checkbox is accessible
    • checkbox is focus-able
    • using spacebar changes state
    • does not trap focus (pressing tab with more than one focus-able element present will move focus to next available element)

Reason for changes:

We want to retroactively implement testing to better protect our codebase

@eburdekin eburdekin added the ready for dev lead task ready for dev lead to evaluate label Sep 27, 2024
@eburdekin eburdekin linked an issue Sep 27, 2024 that may be closed by this pull request
14 tasks
Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eburdekin Yay!! These look great!! Thank you for knocking this out!

@sydneywalcoff sydneywalcoff merged commit 872357c into dev Sep 30, 2024
1 check passed
@eburdekin eburdekin deleted the 1244-checkbox-testing branch October 1, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for dev lead task ready for dev lead to evaluate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox Testing
2 participants