progress bar testing #1246 #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sydneywalcoff
requested changes
Nov 18, 2024
There was a problem hiding this comment.
hey @whitneywind! Great start here!
Can we also make sure that visually it's displaying the correct percentage? So that if the inputted value is 50%, the progress bar should be half filled.
Other than that small addition, great work!!
|
Because the jest tests render the component without the context of a browser window, it won't test the physical length. Instead, it tests for the MUI value that will result in the correct size. |
sydneywalcoff
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
hi @whitneywind ! These look great. Excited to get them merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1246
Changes Made
Wrote tests to check that the progress bar renders correctly and with the correct value.
Action Items
dev