Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1651 filtering sorting dro admin #1990

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Conversation

dipitvasdev
Copy link
Member

@dipitvasdev dipitvasdev commented Dec 4, 2024

Partially addresses: #1651

What changes did you make?

  • Added droList and adminNotesList to handle multi-select filtering for DROs and Admin Notes.
  • Change the filter Function in ProjectsPage.jsx to Include DRO and Admin Notes
  • Modified the TextPopup.jsx Component to Handle DRO and Admin Notes Filtering

Why did you make the changes (we will use this info to test)?

  • To support multi-select filtering for DROs and Admin Notes, droList and adminNotesList were added to the criteria
  • To enable filtering, modified the filtering function
  • For Dro Column modified the Text Popup to include only the specific values dro can take.

Issue-Specific User Account

If you registered a new, temporary TDM User Account for this issue, indicate the
username (i.e., email address) for the account.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

Copy link
Member

@entrotech entrotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work. Since you had the feature branch checked out for a while, some changes were made to the ProjectsPage.js that resulted in merge conflicts. I tried to resolve the conflicts and am merging to develop branch, but you should re-test in the dev environment and make sure it is working as you intended. Then we should present to the PMs and Designers for feedback before showing to the stakeholders.

@entrotech entrotech merged commit bfbaec8 into develop Dec 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants