Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Clear Page" and "Reset Project" on Page 1 #2115

Closed
wants to merge 1 commit into from

Conversation

roslynwythe
Copy link
Member

@roslynwythe roslynwythe commented Feb 10, 2025

Fixes #2066

What changes did you make?

  • The state variable inputValue (representing an incomplete AIN number) was moved up to TdmCalculatorContainer so that it could be cleared by the "Clear Page" button.
  • onUncheckAll was modified to handle the case of the incomplete AIN number

Why did you make the changes (we will use this info to test)?

  • Previously "Clear Page" and "Reset Project" did not work if an incomplete AIN number was present on Page 1. This is because an incomplete AIN number was not in the formInputs or rules and so it was not cleared in the same manner as other inputs

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

no visual changes

…ultiInput to TdmCalculatorContainer so that when the user clicks "Clear Page", the onUncheckAll handler can clear the incomplete (partial) AIN number. Also setInputValue replaced with onPartialMultiChange
@roslynwythe roslynwythe deleted the 2065-clear-page1 branch February 11, 2025 00:43
@roslynwythe
Copy link
Member Author

The PR was closed because I renamed the branch. Opening a new PR..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Clear Page button does not function on Page 1
1 participant