Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where Clear and Reset do not update the AIN on Page 1 #2116

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Fix bug where Clear and Reset do not update the AIN on Page 1 #2116

merged 2 commits into from
Feb 13, 2025

Conversation

roslynwythe
Copy link
Member

@roslynwythe roslynwythe commented Feb 11, 2025 •
edited
Loading

Fixes #2066
Also fixes #2067

What changes did you make?

  • The state variable inputValue (representing an incomplete AIN number) was moved up to TdmCalculatorContainer and renamed partialAIN so that it could be cleared by the "Clear Page" button.
  • The onUncheckAll function was modified to clear incomplete AIN number

Why did you make the changes (we will use this info to test)?

  • Previously "Clear Page" and "Reset Project" did not work if an incomplete AIN number was present on Page 1. This is because an incomplete AIN number was not in the formInputs or rules and so it was not cleared in the same manner as other inputs

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

no visual changes

@roslynwythe
"lift up" the inputValue state variable, as partialMultiInput, from M…
f55115c 
…ultiInput to TdmCalculatorContainer so that when the user clicks "Clear Page", the onUncheckAll handler can clear the incomplete (partial) AIN number. Also setInputValue replaced with onPartialMultiChange
@roslynwythe roslynwythe changed the title "lift up" the inputValue state variable, as partialMultiInput, from M… Fix bug where Clear and Reset do not update the AIN on Page 1 Feb 11, 2025
entrotech
entrotech approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@entrotech entrotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to add one line to the TdmCalculationContainer's onReetProject method to get the reset project feature to work.

@entrotech entrotech merged commit 905fcaf into develop Feb 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@entrotech entrotech entrotech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Reset Project button does not function on Page 1 Bug: Clear Page button does not function on Page 1
2 participants
@roslynwythe @entrotech