Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Profile HFLA Website Essence Goff #7845

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from

Conversation

Eddysunday012
Copy link
Member

@Eddysunday012 Eddysunday012 commented Jan 22, 2025

Fixes #7754

What changes did you make?

  • Added Essence Goff profile to leadership variable in _projects/website.md

Why did you make the changes (we will use this info to test)?

  • Keep information up to date on the website so visitors can get most accurate information

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Screenshot 2025-01-22 at 2 20 25 PM

Visuals after changes are applied

Screenshot 2025-01-22 at 2 20 11 PM

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b Eddysunday012-add-profile-Essence-Goff-7754 gh-pages
git pull https://github.com/Eddysunday012/website.git add-profile-Essence-Goff-7754

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jan 22, 2025
@Eddysunday012 Eddysunday012 changed the title Added Essence Goff profile to leadership Add Profile HFLA Website Essence Goff Jan 22, 2025
@maadeshsivakumar maadeshsivakumar self-requested a review January 25, 2025 16:57
@maadeshsivakumar
Copy link
Member

Review ETA: 6 PM 1/25/25
Availability: 10-8 PM Saturday

@maadeshsivakumar
Copy link
Member

Hi @Eddysunday012 ,

Great job on adding the new profile variable—your implementation looks solid and addresses the issue effectively.

However, I noticed that there are several instances where single quotes have been changed to double quotes throughout the codebase. These formatting changes aren’t related to the current scope of this issue or PR.

Could you please revert the quote changes and just keep the changes that you have made from line 15-21? Keeping PRs focused helps maintain clarity and makes the review process smoother for everyone involved.

Thanks for your understanding!

@Eddysunday012
Copy link
Member Author

Thank you @maadeshsivakumar for reviewing my PR! I undid the changes to the single quotes and only kept the changes for lines 15-21 just like you recommended! I think I accidentally had my prettier extension change it by default when I saved 😅

@siyunfeng
Copy link
Member

@acterin, please comment with your Review ETA and Availability after you've been assigned this PR

Copy link
Member

@maadeshsivakumar maadeshsivakumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Eddysunday012 !

This looks great!

  • The branches from and to are setup correctly
  • Link to the issue is included
  • There is a clear and concise description of what was done and why
  • Visual changes look good

Thank you for your contribution! :)

picture: https://avatars.githubusercontent.com/ExperimentsInHonesty
- name: Essence Goff
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Eddysunday012 ,

Great job on adding the new profile variable—your implementation looks solid and addresses the issue effectively.

However, I noticed that there are several instances where single quotes have been changed to double quotes throughout the codebase. These formatting changes aren’t related to the current scope of this issue or PR.

Could you please revert the quote changes and just keep the changes that you have made from line 15-21? Keeping PRs focused helps maintain clarity and makes the review process smoother for everyone involved.

Thanks for your understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Status: PR Needs review
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Website Add Essence Goff
3 participants