-
-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Terence Lo to Civic Tech Jobs project profile #7861
Added Terence Lo to Civic Tech Jobs project profile #7861
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: EOD, 30/1/25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gmgonzal Great Work! Things you did well:
- The PR was created from the correct branch and properly linked to the corresponding issue Update Project Profile: Civic Tech Jobs Add Terence Lo #7732
- Only the specified section in civic-tech-jobs.md was updated with no unnecessary changes.
- Verified that the changes align with the attached screenshot.
- CodeQL alerts have been checked.
Review ETA: EOD, 30/1/25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled the changes and reviewed Issue #7732. Fixes the issue and comes with the desired effect and proper naming scheme and links. Looking at code, it has everything formatted and linked correctly. Approving this PR.
Fixes #7732
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied