Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Terence Lo to Civic Tech Jobs project profile #7861

Merged

Conversation

gmgonzal
Copy link
Member

@gmgonzal gmgonzal commented Jan 28, 2025

Fixes #7732

What changes did you make?

  • Updated the "leadership" variable to add a profile for Terence Lo in "_projects/civic-tech-jobs.md" file.

Why did you make the changes (we will use this info to test)?

  • To add Terence Lo's profile to the Civic Tech jobs page.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied before
Visuals after changes are applied after

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b gmgonzal-update-add-terence2-7732 gh-pages
git pull https://github.com/gmgonzal/h4la-website.git update-add-terence2-7732

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Status: Updated No blockers and update is ready for review size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jan 28, 2025
@Sujay-Anantha Sujay-Anantha self-requested a review January 30, 2025 18:01
@Sujay-Anantha
Copy link
Member

Review ETA: EOD, 30/1/25
Availability: Mon-Fri

Copy link
Member

@Sujay-Anantha Sujay-Anantha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmgonzal Great Work! Things you did well:

  • The PR was created from the correct branch and properly linked to the corresponding issue Update Project Profile: Civic Tech Jobs Add Terence Lo #7732
  • Only the specified section in civic-tech-jobs.md was updated with no unnecessary changes.
  • Verified that the changes align with the attached screenshot.
  • CodeQL alerts have been checked.

@Cloid
Copy link
Member

Cloid commented Jan 31, 2025

Review ETA: EOD, 30/1/25
Availability: 6pm-11pm weekdays

@Cloid Cloid self-requested a review January 31, 2025 06:18
Copy link
Member

@Cloid Cloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled the changes and reviewed Issue #7732. Fixes the issue and comes with the desired effect and proper naming scheme and links. Looking at code, it has everything formatted and linked correctly. Approving this PR.

@t-will-gillis t-will-gillis merged commit fcbab26 into hackforla:gh-pages Feb 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Status: Updated No blockers and update is ready for review time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Civic Tech Jobs Add Terence Lo
4 participants