Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue number of Mon. Dev/PM meeting agenda #7871

Merged

Conversation

t-will-gillis
Copy link
Member

@t-will-gillis t-will-gillis commented Feb 1, 2025

Fixes #7870

What changes did you make?

  • Updated issue number for Monday PM/dev agenda
  • Added JSDocs comments

Why did you make the changes (we will use this info to test)?

  • Need to reference the correct agenda
  • Adds information explaining function purpose

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Note to PR reviewers: Does not require testing of the "Schedule Monthly" workflow

Copy link

github-actions bot commented Feb 1, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-update-sch-monthly-7870 gh-pages
git pull https://github.com/t-will-gillis/website.git update-sch-monthly-7870

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 1, 2025
@Cloid
Copy link
Member

Cloid commented Feb 3, 2025

Review ETA: EOD 2/02/25
Availability: 5-8 PM Weekdays

@Cloid Cloid self-requested a review February 3, 2025 01:57
Copy link
Member

@Cloid Cloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the action items in Issue #7870, this PR updates the syntax and adds a function comment that aligns more with current coding guidelines. Since workflow testing is not needed and the code has simple syntax changes, I'll approve this PR. Good job!

@belunatic
Copy link
Member

EAT: 2/03/2025 EOD
Aval: MWF 12pm - 2pm

Copy link
Member

@belunatic belunatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t-will-gillis good work on this:

  • Function is correctly updated as requested
  • Global variable properly updated

Few things to get better at:

  • the branch name is preferred to be longer than abbreviated because `...sch-' can be confusing and not understood, so I believe long branch name are accepted.
  • 'What changed?' section, will be great to include the file path of the file you updated; ./github-actions/trigger-schedule/list-inactive-members/create-new-issue.js

But besides that amazing work and thank you!

@t-will-gillis t-will-gillis merged commit ac60169 into hackforla:gh-pages Feb 5, 2025
11 checks passed
@t-will-gillis t-will-gillis deleted the update-sch-monthly-7870 branch February 5, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update "Schedule Monthly" workflow for updated meeting
3 participants