-
-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update issue number of Mon. Dev/PM meeting agenda #7871
Update issue number of Mon. Dev/PM meeting agenda #7871
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: EOD 2/02/25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the action items in Issue #7870, this PR updates the syntax and adds a function comment that aligns more with current coding guidelines. Since workflow testing is not needed and the code has simple syntax changes, I'll approve this PR. Good job!
EAT: 2/03/2025 EOD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@t-will-gillis good work on this:
- Function is correctly updated as requested
- Global variable properly updated
Few things to get better at:
- the branch name is preferred to be longer than abbreviated because `...sch-' can be confusing and not understood, so I believe long branch name are accepted.
- 'What changed?' section, will be great to include the file path of the file you updated;
./github-actions/trigger-schedule/list-inactive-members/create-new-issue.js
But besides that amazing work and thank you!
Fixes #7870
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Note to PR reviewers: Does not require testing of the "Schedule Monthly" workflow