Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Brad Morgan in VMRS leadership #7903

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

Khinememe-Kyaw
Copy link
Member

@Khinememe-Kyaw Khinememe-Kyaw commented Feb 10, 2025

Fixes #7849

What changes did you make?

  • Added Brad Morgan in VRMS leadership

Why did you make the changes (we will use this info to test)?

  • To Keep VRMS up to date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b Khinememe-Kyaw-VRMS-add-7849 gh-pages
git pull https://github.com/Khinememe-Kyaw/website.git VRMS-add-7849

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 10, 2025
@aadilahmed aadilahmed self-requested a review February 10, 2025 08:08
@aadilahmed
Copy link
Member

Review ETA: EOD 2/12/25
Availability: 9-5 PM Monday-Friday

DrAcula27
DrAcula27 previously approved these changes Feb 10, 2025
Copy link
Member

@DrAcula27 DrAcula27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Khinememe-Kyaw Great job on your Good First Issue! Your code passed the ABC's, including:

  • PR is made from the correct branch
  • PR links to the correct issue:
  • The correct file _projects/vrms.md was edited
  • No extra edits were made
  • Appearance of the website looks good (Chrome and Firefox)
    Approved! 👍

@rogerioduenas
Copy link
Member

Hi @DrAcula27,

I resolved a conflict in this PR and your previous review was canceled. I apologize for any inconvenience. I hope I didn't make any mistakes, as I’m new here and still getting used to the workflow. If possible, could you review it again?

Thank you for your understanding! 😁

Copy link
Member

@aadilahmed aadilahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on your first issue @Khinememe-Kyaw ! You added the new profile to the leadership section of the VRMS project page, and correctly created the pull request. Great work!

Copy link
Member

@DrAcula27 DrAcula27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Khinememe-Kyaw Great job on your Good First Issue! Your code passed the ABC's, including:

  • PR is made from the correct branch
  • PR links to the correct issue:
  • The correct file _projects/vrms.md was edited
  • No extra edits were made
  • Appearance of the website looks good (Chrome and Firefox)
    Approved! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Status: PRs ✅ waiting for merge team
Development

Successfully merging this pull request may close these issues.

Update Project Profile: VRMS Add Brad Morgan
4 participants