-
-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Brad Morgan in VMRS leadership #7903
base: gh-pages
Are you sure you want to change the base?
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: EOD 2/12/25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Khinememe-Kyaw Great job on your Good First Issue
! Your code passed the ABC's, including:
- PR is made from the correct branch
- PR links to the correct issue:
- The correct file
_projects/vrms.md
was edited - No extra edits were made
- Appearance of the website looks good (Chrome and Firefox)
Approved! 👍
Hi @DrAcula27, I resolved a conflict in this PR and your previous review was canceled. I apologize for any inconvenience. I hope I didn't make any mistakes, as I’m new here and still getting used to the workflow. If possible, could you review it again? Thank you for your understanding! 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on your first issue @Khinememe-Kyaw ! You added the new profile to the leadership section of the VRMS project page, and correctly created the pull request. Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Khinememe-Kyaw Great job on your Good First Issue
! Your code passed the ABC's, including:
- PR is made from the correct branch
- PR links to the correct issue:
- The correct file
_projects/vrms.md
was edited - No extra edits were made
- Appearance of the website looks good (Chrome and Firefox)
Approved! 👍
Fixes #7849
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied