Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prodigy] scoring module #1069

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

[prodigy] scoring module #1069

wants to merge 21 commits into from

Conversation

VGPReys
Copy link
Contributor

@VGPReys VGPReys commented Oct 1, 2024

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines.

Checklist

  • Tests added for the new code
  • Documentation added for the code changes
  • Does not break licensing
  • Does not add any dependencies, if it does please add a thorough explanation

Summary of the Pull Request

Add a new scoring module [prodigy].

todo:

  • init.py
  • prodigy-prot
  • prodigy-lig
  • Chain reader
  • Defaults:
    • shared parameters
    • Chain selection
    • Ligand selection
  • installation instructions (pip install prodigy-prot prodigy-lig)
  • Fix dependencies issues
  • Third party or NOT ?
  • Examples:
    • prot-prot
    • fix homotrimer issue
    • prot-lig

@VGPReys VGPReys self-assigned this Oct 1, 2024
@VGPReys VGPReys added feature New feature request yaml default parameters Anything related to the YAML configuration files for default parameters examples end-to-end tests / workflow examples labels Oct 1, 2024
@rvhonorato
Copy link
Member

I'm guessing you are still working on it - but keep in mind prodigy is also python so it should be used a library, not as a subprocess call

@VGPReys
Copy link
Contributor Author

VGPReys commented Oct 1, 2024

I'm guessing you are still working on it - but keep in mind prodigy is also python so it should be used a library, not as a subprocess call

maybe indeed a good idea.

@rvhonorato
Copy link
Member

not an idea, it's how it should be done. also keep in mind this could cause a dependency deadlock, so add it as an optional dependency in pyproject.toml

@VGPReys
Copy link
Contributor Author

VGPReys commented Oct 1, 2024

It's already not possible to install both prodigy-prot and prodigy-lig within the same haddock3 env, as they both use different python versions.

@rvhonorato
Copy link
Member

It's already not possible to install both prodigy-prot and prodigy-lig within the same haddock3 env, as they both use different python versions.

so add it as an optional dependency in pyproject.toml

@rvhonorato
Copy link
Member

rvhonorato commented Oct 3, 2024

@VGPReys I've made your life easier by updating the max/min python versions of prodigy and prodigy-lig to match the ones here - so 3.9, 3.10, 3.11 and 3.12, check the latest releases

@VGPReys
Copy link
Contributor Author

VGPReys commented Oct 3, 2024

Nice, indeed will simplify the process

pyproject.toml Outdated Show resolved Hide resolved
@rvhonorato
Copy link
Member

Adding this dependencies will be easier after #1099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples end-to-end tests / workflow examples feature New feature request yaml default parameters Anything related to the YAML configuration files for default parameters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants