#74

haevg-rz · Nov 9, 2021 · 8f1b47f · 8f1b47f
2 parents e8d5dd9 + 6b1ff90
commit 8f1b47f
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/Estimator/Estimator.Tests/Estimator.Tests.csproj b/Estimator/Estimator.Tests/Estimator.Tests.csproj
@@ -5,7 +5,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.11.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.0.0" />
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
       <PrivateAssets>all</PrivateAssets>

diff --git a/Estimator/Estimator.Tests/Pages/CreateRoomTests.cs b/Estimator/Estimator.Tests/Pages/CreateRoomTests.cs
@@ -8,7 +8,7 @@ public class CreateRoomTests
         [Theory]
         [InlineData("Max Mustermann", false)]
         [InlineData("", true)]
-        public void IsUsernameEmptyTest(string userName, bool isUsernameEmptyExpected)
+        public void IsUsernameEmptyTest(string userName, bool isUsernameEmpty)
         {
             #region Assign
 
@@ -17,7 +17,6 @@ public void IsUsernameEmptyTest(string userName, bool isUsernameEmptyExpected)
                 Username = userName
             };
 
-
             #endregion
 
             #region Act

diff --git a/Estimator/Estimator.Tests/Pages/JoinRoomTests.cs b/Estimator/Estimator.Tests/Pages/JoinRoomTests.cs
@@ -11,7 +11,7 @@ public class JoinRoomTests
         [InlineData("12345", "Max Mustermann", false)]
         [InlineData("", "", true)]
         [InlineData("123456", "", true)]
-        public void IsParameterEmptyTest(string roomId, string userName, bool isParameterEmpty)
+        public void IsUsernameOrRoomIdEmptyTest(string roomId, string userName, bool isUsernameOrRoomIdEmpty)
         {
             #region Assign
 
@@ -24,13 +24,13 @@ public void IsParameterEmptyTest(string roomId, string userName, bool isParamete
 
             #region Act
 
-            var result = joinRoom.IsParameterEmpty();
+            var result = joinRoom.IsUsernameOrRoomIdEmpty();
 
             #endregion
 
             #region Assert
 
-            Assert.Equal(isParameterEmpty, result);
+            Assert.Equal(isUsernameOrRoomIdEmpty, result);
 
             #endregion
         }

diff --git a/Estimator/Estimator/Pages/JoinRoom.razor.cs b/Estimator/Estimator/Pages/JoinRoom.razor.cs
@@ -17,7 +17,7 @@ public partial class JoinRoom
         private async void JoinRoomById()
         {
 
-            if(this.IsParameterEmpty())
+            if(this.IsUsernameOrRoomIdEmpty())
             {
                 await Alert("Username or RoomId is empty!");
                 return;
@@ -41,7 +41,7 @@ private async void JoinRoomById()
                 await this.Alert("Something went wrong!");
             }
         }
-        internal bool IsParameterEmpty()
+        internal bool IsUsernameOrRoomIdEmpty()
         {
             return this.Username.Equals(string.Empty) || this.RoomId.Equals(string.Empty);
         }