feat: construction of new_card with images? (closes #36) #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it's a bit of a hack stemming from card fields wanting to be primitive types (in this case a string filename), on top of that it wants the path to relative to the active set - so you _need_ a set to write image files against. That seems a bit contrary to how new_card wants to operate, but I might be understating its usefulness.
haganbmj
commented
Jul 30, 2022
|
|
||
| // If we're dealing with an in-memory image, go ahead and store it to an internal file within the set. | ||
| if (v->type() == ScriptType::SCRIPT_IMAGE) { | ||
| LocalFileName new_image_file = set->newFileName(name, settings.internal_image_extension ? _(".png") : _("")); |
There was a problem hiding this comment.
Should probably pull these out to a common function since this is just the same as what happens when using the slice window.
|
Ain't gonna say it's great, but it's a start to at least demonstrate storing an image during construction.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it's a bit of a hack stemming from card fields wanting to be primitive types (in this case a string filename), on top of that it wants the path to relative to the active set - so you need a set to write image files against. That seems a bit contrary to how new_card wants to operate, but I might be understating its usefulness.