Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update db.py #315

Merged
merged 5 commits into from
Mar 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 28 additions & 12 deletions events/db.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from datetime import timedelta
import hashlib

from sqlalchemy import desc, select, update, func, text
from sqlalchemy import desc, select, update, func, text, and_
from sqlalchemy.sql import exists

from .models import FileAudit, FileUpdate, PermAudit, \
Expand Down Expand Up @@ -58,12 +58,19 @@ def _get_user_activities(session, username, start, limit):
if limit <= 0:
logger.error('limit must be positive')
raise RuntimeError('limit must be positive')

stmt = select(Activity).where(
UserActivity.username == username,
UserActivity.activity_id == Activity.id).\
order_by(desc(UserActivity.timestamp)).\
slice(start, start + limit)

sub_query = (
select(UserActivity.activity_id)
.where(UserActivity.username == username)

)
stmt = (
select(Activity)
.where(Activity.id.in_(sub_query))
.order_by(desc(Activity.timestamp))
.slice(start, start + limit)

)
events = session.scalars(stmt).all()

return [ UserActivityDetail(ev, username=username) for ev in events ]
Expand All @@ -74,11 +81,20 @@ def get_user_activities(session, username, start, limit):
def _get_user_activities_by_timestamp(session, username, start, end):
events = []
try:
stmt = select(Activity).where(
UserActivity.username == username,
UserActivity.timestamp.between(start, end),
UserActivity.activity_id == Activity.id).\
order_by(UserActivity.timestamp)
sub_query = (
select(UserActivity.activity_id)
.where(
and_(
UserActivity.username == username,
UserActivity.timestamp.between(start, end)
)
)
)
stmt = (
select(Activity)
.where(Activity.id.in_(sub_query))
.order_by(Activity.timestamp)
)
events = session.scalars(stmt).all()
except Exception as e:
logging.warning('Failed to get activities of %s: %s.', username, e)
Expand Down
Loading