Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix test.product missing dependencies #1000

Merged
merged 5 commits into from
Nov 21, 2022
Merged

build: fix test.product missing dependencies #1000

merged 5 commits into from
Nov 21, 2022

Conversation

kapil-agnihotri
Copy link
Member

ING-3267

@kapil-agnihotri
Copy link
Member Author

retest this please

1 similar comment
@kapil-agnihotri
Copy link
Member Author

retest this please

@kapil-agnihotri kapil-agnihotri force-pushed the build-fix-test.product-missing-dependencies- branch from 866ee30 to 47d03be Compare November 11, 2022 09:36
@kapil-agnihotri
Copy link
Member Author

retest this please

@kapil-agnihotri kapil-agnihotri force-pushed the build-fix-test.product-missing-dependencies- branch from 4101f8f to 28ec257 Compare November 18, 2022 08:11
@kapil-agnihotri
Copy link
Member Author

Hi @stempler, First time Green build here as well. May be we can merge this so that we can see the product installables in the publish(master).

I tried to include jaxb.runtime dependencies in org.deegree but things didn't work. I was thinking maybe we can merge this PR meanwhile I try few more things in org.deegree before removing the bundle from the application.

@kapil-agnihotri kapil-agnihotri marked this pull request as ready for review November 18, 2022 08:39
@kapil-agnihotri kapil-agnihotri force-pushed the build-fix-test.product-missing-dependencies- branch from ecbfd42 to 44aef1d Compare November 18, 2022 11:24
@kapil-agnihotri kapil-agnihotri force-pushed the build-fix-test.product-missing-dependencies- branch from 44aef1d to a57e750 Compare November 18, 2022 11:54
@kapil-agnihotri
Copy link
Member Author

I have removed org.bundle from Hale.product and Tests.product and have created a GitHub issue for the same #1002.
PR ready for review.

@kapil-agnihotri kapil-agnihotri force-pushed the build-fix-test.product-missing-dependencies- branch from 44b0abb to c4be00c Compare November 18, 2022 12:55
stempler
stempler reviewed Nov 18, 2022
View reviewed changes
...o.geopackage.test/src/eu/esdihumboldt/hale/io/geopackage/GeopackageInstanceWriterTest.groovy Outdated
@@ -191,7 +190,8 @@ class GeopackageInstanceWriterTest {
}

abc {
a(new BigInteger('1' + Long.MAX_VALUE))

a(new BigInteger(''+Long.MAX_VALUE))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but I would at least add a comment here, that it used to work with '1' + Long.MAX_VALUE and it does no longer for an unknown reason.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a comment.

@kapil-agnihotri
build: fix BigInteger failing test case
6f66a00 
Adding 1 to Long.MAX_VALUE results in `overflow` exception
when converting BigInteger string into Long.
So added an empty string instead of adding 1

ING-3267
@kapil-agnihotri kapil-agnihotri force-pushed the build-fix-test.product-missing-dependencies- branch from e54f624 to 6f66a00 Compare November 21, 2022 09:36
@kapil-agnihotri kapil-agnihotri merged commit 9d7c95a into halestudio:master Nov 21, 2022
@kapil-agnihotri kapil-agnihotri deleted the build-fix-test.product-missing-dependencies- branch November 21, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stempler stempler stempler approved these changes

@florianesser florianesser Awaiting requested review from florianesser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kapil-agnihotri @stempler